Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing import of annif.eval in MLLM backend #562

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

osma
Copy link
Member

@osma osma commented Jan 31, 2022

The MLLM backend was missing an import of annif.eval. This didn't always cause issues because usually it was imported by other modules such as annif.cli. It may have caused tests to occasionally hang on GitHub Actions CI.

This PR simply adds the missing import.

@osma osma added the bug label Jan 31, 2022
@osma osma added this to the 0.56 milestone Jan 31, 2022
@osma osma self-assigned this Jan 31, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #562 (4d50840) into master (4fba412) will increase coverage by 4.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
+ Coverage   95.03%   99.50%   +4.46%     
==========================================
  Files          82       82              
  Lines        5443     5444       +1     
==========================================
+ Hits         5173     5417     +244     
+ Misses        270       27     -243     
Impacted Files Coverage Δ
annif/backend/mllm.py 100.00% <100.00%> (ø)
tests/conftest.py 100.00% <0.00%> (+1.20%) ⬆️
annif/analyzer/__init__.py 100.00% <0.00%> (+3.22%) ⬆️
tests/test_project.py 100.00% <0.00%> (+7.34%) ⬆️
annif/backend/__init__.py 100.00% <0.00%> (+13.20%) ⬆️
tests/test_backend.py 100.00% <0.00%> (+15.78%) ⬆️
annif/backend/mixins.py 95.12% <0.00%> (+24.39%) ⬆️
tests/test_analyzer_spacy.py 100.00% <0.00%> (+80.00%) ⬆️
tests/test_backend_fasttext.py 100.00% <0.00%> (+92.94%) ⬆️
annif/backend/fasttext.py 100.00% <0.00%> (+93.47%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fba412...4d50840. Read the comment docs.

@osma
Copy link
Member Author

osma commented Jan 31, 2022

Unfortunately this didn't fix the hanging tests, but it's still a problem worth fixing, so I'm merging this anyway.

@osma osma merged commit 52d70b8 into master Jan 31, 2022
@osma osma deleted the fix-mllm-import-annif-eval branch January 31, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant