Support TOML as a configuration file format alongside CFG/INI. #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osma
force-pushed
the
issue547-config-toml-format
branch
from
27f381b
to
66dcebd
Compare
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
========================================
Coverage 99.46% 99.47%
========================================
Files 82 84 +2
Lines 5444 5544 +100
========================================
+ Hits 5415 5515 +100
Misses 29 29
Continue to review full report at Codecov.
|
osma
force-pushed
the
issue547-config-toml-format
branch
from
66dcebd
to
b816e71
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Annif efficiently with DVC requires that DVC understands the Annif configuration file; the current INI-style format is not supported by DVC (see #547).
This PR adds support for TOML as a configuration file format alongside the current one (which still works). Unless the path to the configuration file has been set using the
ANNIF_PROJECTSenvironment variable or the-pcommand line option, the configuration will be read fromprojects.cfgif it exists, otherwise fromprojects.toml.The main difference in the configuration syntax is that TOML requires string values to be quoted, e.g.
instead of
The tomli parser is used for parsing project configuration files with a
.tomlextension. It's a very minimal read-only, pure Python TOML parser; in the future, similar functionality (based on tomli) may be included in the Python standard library - see PEP 680.Fixes #547
Opening as draft PR to get early feedback from CI tools. Probably some refactoring will be necessary, as well as additional unit tests.