Allow selecting installed optional dependencies in Docker build #548

juhoinkinen · 2021-12-21T09:55:46Z

Currently we provide a Dockerfile and an image in quay.io with dependencies for all the optional features.

If someone does not need all the features, but e.g. uses only Omikuji backend and would like build their own image (e.g. for smaller size), they could edit the Dockerfile dropping the unwanted (Python) dependencies from the pip install command. However, using --build-arg option of docker build provides a way to pass the user-defined list of dependencies to install that overrides the default list:

docker build -t annif-omikuji-voikko --build-arg optional_dependencies=omikuji,voikko .

A user wanting to have a Docker image to use with Xtransfomer could add pecos to the default list in build time.

codecov · 2021-12-21T09:56:23Z

Codecov Report

Merging #548 (38adcf8) into master (5c6af91) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #548   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          80       80           
  Lines        5313     5313           
=======================================
  Hits         5286     5286           
  Misses         27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c6af91...38adcf8. Read the comment docs.

osma · 2021-12-21T10:13:17Z

What about fasttext? It will be installed regardless of this setting, right?

juhoinkinen · 2021-12-21T10:28:25Z

What about fasttext? It will be installed regardless of this setting, right?

Yes, that's true, I thought it would not be installed... Or at least not available right away. Hmm, I don't if its copying from builder stage can be controlled this way conveniently enough.

osma · 2021-12-21T10:47:08Z

I don't think always including fasttext is a very big deal, this PR is still a big improvement.

That said, I think it could be possible to avoid installing fasttext by making the pip install command on line 9 conditional. Something like:

if [[ $optional_dependencies =~ "fasttext" ]]; then pip install --no-cache-dir fasttext==0.9.2; fi

(perhaps the apt-get install build-essential command could be moved inside the if clause as well, to avoid doing useless extra work in case fasttext isn't needed)

The ARG declaration needs to be moved earlier of course.

The COPY command would then copy an empty /usr/local/lib/python3.8 directory from the builder image.