Declare dateutil dependency #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pulled in via optuna/alembic
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
=======================================
Coverage 99.52% 99.52%
=======================================
Files 82 82
Lines 5874 5874
=======================================
Hits 5846 5846
Misses 28 28 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http backend uses dateutil (since PR #432). This library was previously pulled in indirectly via alembic that optuna depends on. But the latest version of alembic makes this dependency optional, so it's no longer installed alongside optuna - and now installs are broken and CI tests are failing.
In any case, it's good practice to declare explicit dependencies to all the modules used in the codebase.