Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow private projects to be accessed from CLI #522

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

osma
Copy link
Member

@osma osma commented Aug 20, 2021

Fixes #521

The intent was always that private projects can be accessed from CLI; the access setting only applies to the REST API. But this wasn't actually the case; hidden projects couldn't be used from most CLI commands due to a simple bug, fixed in this PR.

@osma osma added the bug label Aug 20, 2021
@osma osma added this to the 0.54 milestone Aug 20, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #522 (883e442) into master (2da4a34) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
+ Coverage   99.51%   99.53%   +0.01%     
==========================================
  Files          82       82              
  Lines        5830     5830              
==========================================
+ Hits         5802     5803       +1     
+ Misses         28       27       -1     
Impacted Files Coverage Δ
annif/cli.py 99.62% <100.00%> (ø)
annif/backend/stwfsa.py 100.00% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da4a34...883e442. Read the comment docs.

@osma osma merged commit 8660e37 into master Aug 20, 2021
@osma osma deleted the fix-access-private-from-cli branch August 20, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to use a private project returns "No projects found with id" from inside command line.
1 participant