Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKOS graph cache enhancements #519

Merged
merged 2 commits into from
Aug 19, 2021
Merged

SKOS graph cache enhancements #519

merged 2 commits into from
Aug 19, 2021

Conversation

osma
Copy link
Member

@osma osma commented Aug 19, 2021

This is a follow-up to PR #513 which introduced caching for parsed SKOS graphs as joblib dumps. Two small improvements:

  • the filename is now subjects.dump.gz instead of subjects.joblib.gz which is hopefully a bit more descriptive
  • annif.util.atomic_save is used to avoid file corruption problems in case the dumping gets interrupted

@osma osma added this to the 0.54 milestone Aug 19, 2021
@osma osma self-assigned this Aug 19, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #519 (335de98) into master (b17448e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #519   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          82       82           
  Lines        5828     5829    +1     
=======================================
+ Hits         5800     5801    +1     
  Misses         28       28           
Impacted Files Coverage Δ
annif/corpus/skos.py 98.14% <100.00%> (+0.03%) ⬆️
annif/vocab.py 100.00% <100.00%> (ø)
tests/test_cli.py 100.00% <100.00%> (ø)
tests/test_vocab.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17448e...335de98. Read the comment docs.

@osma osma merged commit 4af819f into master Aug 19, 2021
@osma osma deleted the feature-skos-graph-cache-part2 branch August 19, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant