-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support jobs parameter in train command #512
Conversation
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 82 82
Lines 5774 5786 +12
=======================================
+ Hits 5746 5758 +12
Misses 28 28
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fixed test coverage. Tested this with fasttext and omikuji backends; by default both will use all CPUs, but setting the Ready for review. |
This PR adds a new
jobs
parameter for theannif train
command, similar to the one already implemented ineval
andhyperopt
commands. The intent is to make it easier to control the amount of threads/CPUs used for training, for those backends that can make use of parallel processing during training.The PR adds this support to the fasttext and Omikuji backends, for which this was simple to implement.
Adding as draft PR for now, since this needs more testing and QA tool checks.
This is a sideshoot of PR #511 which will benefit from this, but I thought it was cleaner to implement it as a separate PR.