Warn instead of error in case of multiple subjects per doc in SVC training #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juhoinkinen
added
enhancement
classification
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
+ Coverage 99.51% 99.53% +0.01%
==========================================
Files 82 82
Lines 5784 5771 -13
==========================================
- Hits 5756 5744 -12
+ Misses 28 27 -1
Continue to review full report at Codecov.
|
osma
reviewed
Aug 10, 2021
|
LGTM. Suggested an extremely minor change for you to consider before merging. |
juhoinkinen
force-pushed
the
warn-on-multiple-subjects-for-svc
branch
from
3a5adb6
to
13a3c9e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
juhoinkinen
added a commit
that referenced
this pull request
Aug 10, 2021
…aining (#509) * Warn instead of error in case of multiple subjects per doc for SVC * Remove now unnecessary single-subject-document-corpus fixture * Avoid creating list of uris
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #501 fixed training SVC on full-text corpus, and also added raising
NotSupportedExceptionif any training document had multiple uris (as SVC is a multi-class, not multi-label algorithm). However in real-life even in those data-sets meant to have only one subject per doc there can be some docs with many subjects. To allow training SVC on such data sets, this PR changes the error to warning, and lets a random one of the uris to be used as the target uri.