Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #498

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Update Dockerfile #498

merged 2 commits into from
Jun 15, 2021

Conversation

juhoinkinen
Copy link
Member

@juhoinkinen juhoinkinen commented Jun 15, 2021

This

  • updates Docker image to use Python 3.8
  • changes dependencies to be installed from setup.py (pip install .[voikko,...]) instead of installing with separate pip call (thus removing need to have versions pinned in both setup.py and Dockerfile)
  • removes unnecessary installation and linking steps in build-stage (nowdays Vowpal Wabbit has wheel in PyPI)
  • reorders layers a bit (Annif source is copied after dependencies are installed, so build should be faster)
  • installs Yake in Docker image

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #498 (d0bb31d) into master (a29900e) will decrease coverage by 5.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
- Coverage   99.50%   93.66%   -5.84%     
==========================================
  Files          78       78              
  Lines        5669     5669              
==========================================
- Hits         5641     5310     -331     
- Misses         28      359     +331     
Impacted Files Coverage Δ
tests/test_backend_vw_multi.py 3.94% <0.00%> (-95.40%) ⬇️
annif/backend/vw_multi.py 2.50% <0.00%> (-95.00%) ⬇️
annif/analyzer/voikko.py 10.52% <0.00%> (-84.22%) ⬇️
tests/test_analyzer_voikko.py 25.00% <0.00%> (-75.00%) ⬇️
annif/analyzer/__init__.py 97.56% <0.00%> (-2.44%) ⬇️
annif/backend/__init__.py 98.07% <0.00%> (-1.93%) ⬇️
annif/backend/stwfsa.py 98.48% <0.00%> (-1.52%) ⬇️
tests/test_cli.py 98.93% <0.00%> (-1.07%) ⬇️
annif/cli.py 99.24% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29900e...d0bb31d. Read the comment docs.

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa! All these improvements, and the Dockerfile is now almost 40 lines shorter :) Great work!

Dockerfile Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@juhoinkinen juhoinkinen merged commit 0fe6557 into master Jun 15, 2021
@juhoinkinen juhoinkinen deleted the update-dockerfile branch June 15, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants