Raise NotSupportedException for attempt to train YAKE #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
+ Coverage 99.47% 99.49% +0.01%
==========================================
Files 76 76
Lines 5513 5520 +7
==========================================
+ Hits 5484 5492 +8
+ Misses 29 28 -1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that a user could try to train a Yake project (which is unnecessary Yake being unsupervised algorithm), but training would seem to succeed, although actually nothing happens.
A more correct behavior is to raise
NotSupportedExceptionwhen training a Yake project is attempted, as in the case of the Ensemble backend.