Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address SonarCloud complaint: use strings in __all__ statement #454

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

osma
Copy link
Member

@osma osma commented Dec 8, 2020

This PR addresses a number of similar complaints by SonarCloud: the __all__ list defined in __init__.py should consists of strings.

@osma osma added the bug label Dec 8, 2020
@osma osma added this to the 0.51 milestone Dec 8, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #454 (503641a) into master (846ebaf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files          65       65           
  Lines        4625     4625           
=======================================
  Hits         4598     4598           
  Misses         27       27           
Impacted Files Coverage Δ
annif/corpus/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 846ebaf...503641a. Read the comment docs.

@osma osma merged commit c26f09d into master Dec 8, 2020
@osma osma deleted the fix-module-all-strings branch December 8, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant