Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit parameter is not passed to MauiServer #459

Closed
juhoinkinen opened this issue Dec 18, 2020 · 1 comment · Fixed by #460
Closed

Limit parameter is not passed to MauiServer #459

juhoinkinen opened this issue Dec 18, 2020 · 1 comment · Fixed by #460
Labels
Milestone

Comments

@juhoinkinen
Copy link
Member

juhoinkinen commented Dec 18, 2020

Maui backend gives at most 10 suggestions even if a larger limit value is set in Annif.

At training time only id and lang parameters are passed to MauiServer, and the default value of 10 is always used for max_topics_per_document.

# http://localhost:8080/mauiserver/tmp-maui-fi/config

id | "tmp-maui-fi"
-- | --
title | "tmp-maui-fi"
description | null
lang | "fi"
stemmer_class | null
stopwords_class | null
cross_validation_passes | 10
max_topics_per_document | 10
probability_threshold | 0

When Maui backend is used in an ensemble project, getting more suggestions would be advantageous.

@juhoinkinen juhoinkinen added this to the Short term milestone Dec 18, 2020
@osma
Copy link
Member

osma commented Jan 7, 2021

Good catch! This should be relatively easy to fix - just pass the configured limit value to Maui as max_topics_per_document.

It does mean that the limit used by Maui will be fixed during train time, unlike for other backends where it's applied only during suggest operations. I don't think this is a major problem but could perhaps be noted on the wiki page of the Maui backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants