Merged
Conversation
added 26 commits
May 7, 2021 12:06
…of the pvwatts model
…ake code apart to hook it up to the cec module model
…ndia inverter ac power function so that not all results must be retrieved
removed my previously added outputs for estimated system configuration because they are misleading, and instead added outputs for timeseries shading derates. added tests of these derates. also updated logic for calculating system layout in pvwattsv8, and updated tests with new results. one test still throwing SEH error.
sjanzou
approved these changes
Oct 27, 2021
Collaborator
sjanzou
left a comment
sjanzou
left a comment
There was a problem hiding this comment.
Looks good, thanks for adding the tests!
mjprilliman
approved these changes
Oct 27, 2021
Collaborator
mjprilliman
left a comment
mjprilliman
left a comment
There was a problem hiding this comment.
LGTM. Got an SEH exception on the NonAnnual test on Windows but I believe we said those are fine.
Collaborator
Author
|
Yes @mjprilliman , I got that same exception if I ran the test through Test.exe but not if I ran it through the Test Explorer on Windows, which we think is a known issue with all the NonAnnual tests. Thanks both for your reviews! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds PVWattsV8 as detailed in, and fixes #629 . All tests are passing. Additional comparisons between v5 results and v8 results will be detailed in a technical report.