This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
First class static content #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable it users now need to do StaticContent.Enable(pipelines) Updated tests accordingly.
WCF forces us to specify a content type, even though we're sending no body, although I can't say it's a huge surprise to see WCF breaking HTTP.. *sigh*
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved static content to be "first class" so it now runs before the main pipeline, security etc.
If secure content is required, It's possible to disable the new hook by setting it to DisabledStaticContentProvider in NancyInternalConfiguration, then calling StaticContent.Enable to enable to old style, pipeline based, static content.
Also added automatically responding to conditional requests (based on etag or last modified), and returning 304 as appropriate.