This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Make IUserIdentity immutable #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity instead of a A.Fake<IUserIdentity>
|
👍 |
|
Pushing this back as it's a breaking change that may need more discussion (someone may be rewriting the username in a hook for instance for impersonation) |
|
Fair enough. Not sure rewriting the username would be a good way to do impersonation though. Shall I bring it up with the group? |
|
Tbh, I'm probably worried about nothing, but seeing as we're mid-release I'd rather park it for 0.17 so I can think about it more :) |
|
No problem with that. It's not like it's a serious bug or anything. I have mild OCD :) |
grumpydev
added a commit
that referenced
this pull request
Feb 17, 2013
Make IUserIdentity immutable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here.
8d7210f#commitcomment-2607687