This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Nancy module split #906
Merged
Nancy module split #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm guessing it is because of R# and not your doing, but there are a ton of changes in this PR that are just added |
| using Nancy.ViewEngines; | ||
|
|
||
| /// <summary> | ||
| /// Nancy base class |
There was a problem hiding this comment.
It's not a base class so I would change it into something like "Defines the core functionality of a module in Nancy"
|
Other than the review comments it looks good :-) |
The idea being that the "core" functionality only relies on the base, with the minimal amount of properties on it, leaving the end users free to implement their own route builders etc.
Obviously it wasn't going to work in the builder as you add to the pipelines in the module ctor :P
It was re-running the select statement and makign the assumption that would return the same instances as the original - which in this case it wasn't
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits NancyModule into INancyModule and NancyModule, with the framework only relying on the properties present in the interface.
Also added a sample of a new nancy module type, which uses attributes to define routes, to show the flexibility this brings.