This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Case sensitivity options #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spooky, Andreas was only talking to me about this, and the previous forum discussion, on Friday :-) |
|
Well, I was talking to him about it (possibly Friday) in the context of the OAuth changes and how the case is specified in the spec. |
|
@nathanpalmer can you rebase this rather than merging please? That commit from the 13th will make the history look messy :-) |
Modified DynamicDictionary along with the Merge in CollectionExtensions to enable/disabled based on configuration. Added a few tests for it
|
Agreed. It's been rebased now. |
|
That was quick.. thanks :-) |
|
Nice I actually had a wrapper for the dynamic dictionary to help with this. This will be most handy. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a way to disable case sensitivity within query, parameters and model binding. It's currently configurable through StaticConfiguration.
Two things to note...
I changed the generic version of Merge in CollectionExtensions to a non-generic version that works on strings. I originally had an overload but as this is only used in one place I decided to just change the main version.
Also the case sensitivity options change DynamicDictionary. This is affecting many of the things we need it to in order to accomplish the goal. However, let me know if you think of something that uses DynamicDictionary that SHOULDN'T have this option.
Here is a reference to the old thread where a discussion on this started
http://groups.google.com/group/nancy-web-framework/browse_thread/thread/c5bb96dae8cc0821/bad96cbc7f021b5b?lnk=gst&q=case+sensitive#bad96cbc7f021b5b
Nathan Palmer