This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Tweaked overloads of Dependency and Dependencies #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could actually be a minor breaking change, since people could've used the old method to register all kinds of different types, and the compiler won't be able to infer the type anymore. The fix is as simple as helping the compiler out by specifying an explicit type, like I had to do here. |
|
Rebased 😉 |
thecodejunkie
added a commit
that referenced
this pull request
Aug 19, 2015
Tweaked overloads of Dependency and Dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1909
The old
Dependenciesmethod took aparams object[] dependenciesargument, looped through them and calledthis.Dependency<T>(dependency)whereTwas inferred toobject😕 I can't see how this has ever worked.This PR removes the overloads accepting
objectandobject[]and force you to use an overload with an explicit (or inferred) generic type parameter.