This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Break when status code has been handled #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khellang
changed the title
|
This could potentially be a breaking change if people rely on multiple status code handlers to handle a specific status code. It's a weird edge case, though. |
| .FirstOrDefault(x => !(x is DefaultStatusCodeHandler)); | ||
|
|
||
| var handler = customHandler ?? defaultHandler; | ||
| if (handler == null) |
There was a problem hiding this comment.
If the DefaultStatusCodeHandler has been removed, it could be null. Better safe than sorry 😉
khellang
force-pushed
the
single-status-code-handler
branch
from
7f57b20 to
7bac92f
Compare
thecodejunkie
added a commit
that referenced
this pull request
Aug 19, 2015
Break when status code has been handled
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1667. I don't think it makes sense to run through all status code handlers even after one has been called. This will try to find a custom handler and fall back on the
DefaultStatusCodeHandlerif no custom handler is found.