This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Tracelog refactoring #1477
Merged
Tracelog refactoring #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced IRequestTrace interface - Renamed RequesetTrace to DefaultRequestTrace - Introduced RequestData and ResponseData - Introduced IRequestTraceFactory interface - Implemented DefaultRequestTraceFactory - Updated DefaultNancyContextFactory to use IRequestTraceFactory - Added missing XML comments
|
|
👍
|
This is going to allow some more Glimpse.Nancy awesomesauce. Hurry up and release it already ;) |
| /// <summary> | ||
| /// Creates a new instance of the <see cref="DefaultDiagnostics"/> class. | ||
| /// </summary> | ||
| /// <param name="diagnosticsConfiguration"></param> |
jrsconfitto
added a commit
to jrsconfitto/Nancy.EmbeddedContent
that referenced
this pull request
Jun 6, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the initialization of the trace log was hard-coded in the
NancyContext. This pull-request introduces theIRequestTraceFactoryconcept which provided a factory for setting up the request trace stuff.IRequestTraceinterfaceRequesetTracetoDefaultRequestTraceRequestDataandResponseDataIRequestTraceFactoryinterfaceDefaultRequestTraceFactoryDefaultNancyContextFactoryto useIRequestTraceFactoryStaticConfigurationContextclass toNancy.Testing