Adds charset=utf8 to a json response Content-Type

[albertjan]

No description provided.

[grumpydev]

Is there any downside/breaking issues with making this the default? Feels odd not making it more configurable/overridable.

[albertjan]

I'm all for making it configurable. Should i put it in a static property on the JsonResponse? But I would make this the default though since almost all json serialisers serialise with UTF8.

[thecodejunkie]

The only breaking change I can see is if there is someone that explicitly string matches against the content type in something like an after-hook

[thecodejunkie]

@albertjan @grumpydev I know you guys talked a bit more about the "making it more configurable/overridable" part. Did you reach a conclusions?

[prabirshrestha]

It could be a part of JsonSettings.

https://github.com/NancyFx/Nancy/blob/master/src/Nancy/Json/JsonSettings.cs

public static string DefaultCharset { get; set; }

Jsonp call could also use this. https://github.com/NancyFx/Nancy/blob/master/src/Nancy/Jsonp.cs#L59
Currently it uses the following code context.Response.ContentType = "application/javascript"; or add JsonpSettings.

[albertjan]

@thecodejunkie, @grumpydev you concur with @prabirshrestha sugestion?

[albertjan]

Will do some reformatting tomorrow at work "Xamarin Studio" doesn't play nice.

[grumpydev]

Some weird formatting and spacing issues in JsonResponse.cs (brackets look out of line, spaces before opening method parens)

[thecodejunkie]

@albertjan This is breaking on mono, see the Travis CI log please. we'd like to get this into 0.18 so the sooner the better

[albertjan]

@thecodejunkie no there isn't :) @grumpydev told me this test is a rogue test that will sometimes break on mono builds.