Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Rename IErrorHandler to IStatusCodeHandler #800

Closed
jchannon opened this issue Nov 1, 2012 · 0 comments · Fixed by #808
Closed

Rename IErrorHandler to IStatusCodeHandler #800

jchannon opened this issue Nov 1, 2012 · 0 comments · Fixed by #808
Assignees
@thecodejunkie
Milestone
0.14

Comments

@jchannon
Copy link
Member

jchannon commented Nov 1, 2012

After reviewing IErrorHandler and pipelines.OnError it seemed confusing which one to use. After investigation and info from @thecodejunkie IErrorHandler is more designed to handle certain HTTP status code errors.

Therefore could we rename IErrorHandler to IStatusCodeHandler?
@ghost ghost assigned thecodejunkie Nov 5, 2012
thecodejunkie added a commit to thecodejunkie/Nancy that referenced this issue Nov 5, 2012
@thecodejunkie
Renamed IErrorHandler to IStatusHandler
9527d9f 
Seems more appropriate since it can be used to handle all kinds of
status codes.

Fixes NancyFx#800
@thecodejunkie thecodejunkie mentioned this issue Nov 5, 2012
Merged
luuksommers pushed a commit to luuksommers/Nancy that referenced this issue Dec 1, 2012
@thecodejunkie @luuksommers
Renamed IErrorHandler to IStatusHandler
050e9ef 
Seems more appropriate since it can be used to handle all kinds of
status codes.

Fixes NancyFx#800
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thecodejunkie thecodejunkie

Labels
None yet
Projects
None yet
Milestone
0.14
Development

Successfully merging a pull request may close this issue.

Renamed IErrorHandler to IStatusHandler thecodejunkie/Nancy
2 participants
@thecodejunkie @jchannon