Namui New http wrapping #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Cargo.lock JS side is finished. Keep going on rust side Update Cargo.lock Test with sample is done. need to handle error Wire up error handling Handle error Windows build Update Cargo.lock Fix error
namse
force-pushed
the
namui/network-http
branch
from
b9309dc to
1d9404b
Compare
namse
commented
Sep 4, 2024
bigfoodK
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes http crate as interface for http request and response.
I put some Extension traits of http::Request and http::Response, so user can send and receive using that trait.
Implementation Status
Windows: need tokio update (tokio-rs/tokio#6822), because hyper-util's dns system use original tokio.
Wasi: Works well.
google's fail is natural because google server blocks our request by cors policy.
Additional changes
new-event-systemadded. I will put every js-rs event things in here, including pre-made other event systems, like websocket, screen, etc.