Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use magic keywords to detect issue linking #95

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Conversation

Namchee
Copy link
Owner

@Namchee Namchee commented Oct 22, 2023

Overvivew

Closes #93.

This pull request fixes issue requirements validator by detecting closing keywords in the pull request body.

While this is a good enough solution, this solution cannot detect issue link perfectly if it's linked manualy which has already been explained in the documentation. Further fixes will be tracked by #94.

@Namchee Namchee merged commit cc86d48 into master Oct 22, 2023
@Namchee Namchee deleted the fix/issue-linking branch December 21, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR links to an issue validation is broken
1 participant