Documented the fix for trick 153 (PR #272)

NagyD · Feb 19, 2022 · 211796b · 211796b
1 parent 04b44fa
commit 211796b
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/doc/ChangeLog.txt b/doc/ChangeLog.txt
@@ -674,3 +674,6 @@ DONE: Added support for reading mirror_column from the EXE if it's different fro
 	(For Shauing's upcoming mod.)
 DONE: Added support for changing where the shadow steals the potion and steps on the button.
 	(For Shauing's upcoming mod.)
+DONE: Added a configurable fix for trick 153
+	Details: See FIX_DROP_2_ROOMS_CLIMBING_LOOSE_TILE in config.h and https://github.com/NagyD/SDLPoP/pull/272
+	Testcase: doc/replays-testcases/trick_153.p1r
diff --git a/doc/replays-testcases/trick_153.p1r b/doc/replays-testcases/trick_153.p1r
diff --git a/doc/replays-testcases/trick_153.txt b/doc/replays-testcases/trick_153.txt
@@ -0,0 +1,5 @@
+The prince should not end up in the room below the room where he starts.
+To pass the test: #define SETTING_FIX_DROP_2_ROOMS_CLIMBING_LOOSE_TILE in config.h and enable settings -> gameplay -> Fix dropping 2 rooms with loose tile.
+
+More info: https://github.com/NagyD/SDLPoP/pull/272
+https://www.popot.org/documentation.php?doc=TricksPage4#153
diff --git a/src/config.h b/src/config.h
@@ -277,6 +277,8 @@ The authors of this program may be contacted at https://forum.princed.org
 // The prince can fall down 2 rooms while climbing a loose tile located in the room above. (Trick 153)
 // It happens when the player hangs on the loose tile holding Shift for a second before climbing up.
 // The fix ensures the tile does not start to fall until the climbing sequence changes prince's current row.
+// Testcase: doc/replays-testcases/trick_153.p1r
+// See also: https://github.com/NagyD/SDLPoP/pull/272
 #define FIX_DROP_2_ROOMS_CLIMBING_LOOSE_TILE
 
 #endif // ifndef DISABLE_ALL_FIXES