Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker builds by pinning PIP version #1549

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Fix docker builds by pinning PIP version #1549

merged 1 commit into from
Jan 27, 2021

Conversation

jonathangreen
Copy link
Contributor

@jonathangreen jonathangreen commented Jan 27, 2021

Looks like PIP 21.0 is out and it drops Python 2 support which breaks our docker builds:
pypa/pip#6148

This should pin PIP in the docker install by pinning pip to a version that works with Python 2.

This should fix the docker containers that didn't build on this merge: a22e205

Copy link
Collaborator

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to assume that you're done, but this looks like it should do the trick.

@jonathangreen
Copy link
Contributor Author

Thanks @tdilauro! Yes, should be good to go from my perspective.

@leonardr leonardr merged commit 70e69ac into NYPL-Simplified:develop Jan 27, 2021
@leonardr
Copy link
Contributor

Thanks for taking care of this.

@jonathangreen jonathangreen deleted the upstream/pin_pip_version branch January 27, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants