-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement callback in sim_ber #254
Comments
Hi, Thank you for the proposal. This feature is certainly useful for long-running simulations. Would you be interested in making a pull-request to integrate it into Sionna? Just a remark: this topic belongs more to the discussions than issues section. |
Can I send you a patch instead? This patch implements both of the features
(stop at min ber + callback).
…On Tue, Nov 7, 2023 at 10:52 AM SebastianCa ***@***.***> wrote:
Hi,
Thank you for the proposal. This feature is certainly useful for
long-running simulations. Would you be interested in making a pull-request
to integrate it into Sionna?
Just a remark: this topic belongs more to the discussions than issues
section.
—
Reply to this email directly, view it on GitHub
<#254 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA4VUBT2AELLVZSVWF5R7DYDJKMZAVCNFSM6AAAAAA7BE7BHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJZGAYDMNBRHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*Those who don't understand recursion are doomed to repeat it*
|
Unfortunately, we cannot merge such a patch directly due to licensing issues as it would incorrectly attribute your work as ours. You would need to submit a Pull Request with a signed-off commit, ensuring proper authorship is documented. |
I have produced a PR for this. This is the 1st time I've gone through this PR process so I hope I did it correctly. |
Please see #257 for further discussion. |
I have many long-running sims and need to implement logging. To facilitate this I added a callback to sim_ber that can be used to log intermediate results.
The callback sig is:
def log_bler(esno_dbs, bit_errors, block_errors, nb_bits, nb_blocks):
The text was updated successfully, but these errors were encountered: