Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement callback in sim_ber #254

Closed
nbecker opened this issue Nov 7, 2023 · 5 comments
Closed

implement callback in sim_ber #254

nbecker opened this issue Nov 7, 2023 · 5 comments

Comments

@nbecker
Copy link
Contributor

nbecker commented Nov 7, 2023

I have many long-running sims and need to implement logging. To facilitate this I added a callback to sim_ber that can be used to log intermediate results.

The callback sig is:
def log_bler(esno_dbs, bit_errors, block_errors, nb_bits, nb_blocks):

@SebastianCa
Copy link
Collaborator

Hi,

Thank you for the proposal. This feature is certainly useful for long-running simulations. Would you be interested in making a pull-request to integrate it into Sionna?

Just a remark: this topic belongs more to the discussions than issues section.

@nbecker
Copy link
Contributor Author

nbecker commented Nov 7, 2023 via email

@SebastianCa
Copy link
Collaborator

Unfortunately, we cannot merge such a patch directly due to licensing issues as it would incorrectly attribute your work as ours. You would need to submit a Pull Request with a signed-off commit, ensuring proper authorship is documented.

@nbecker
Copy link
Contributor Author

nbecker commented Nov 8, 2023

I have produced a PR for this. This is the 1st time I've gone through this PR process so I hope I did it correctly.

@SebastianCa
Copy link
Collaborator

Please see #257 for further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants