Fix type mismatch when non-default float types are used in sparse_reduce #17
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
sparse_reduce
does not specify dtype when initializingnew_out_features
with zeros:WarpConvNet/warpconvnet/nn/functional/sparse_pool.py
Lines 98 to 102 in d9082e8
This leads to an error when using any type other than
torch.float32
:This commit fixes the issue. I have also looked through all other uses of
torch.zeros
in the code. I did not find any other parts that do not specify a data type save for one line:WarpConvNet/warpconvnet/nn/modules/mlp.py
Line 92 in d9082e8
But since it's part of initializing a module, it should probably be fine, as the types of module weights are usualy cast all at once once the model was fully instantiated.