Modify USD and OBJ importers for correctness, consistency and convenience #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling of material assignments, fix bugs, add option to triangulate. Non-backward compatible changes to OBJ importer, including: - renamed vertex_normals to normals and fixed doc (this value is normals array is not num_verts x 3, but num_normals x 3) - renamed face_normals to face_normals_idx, which is more accurate - changed material_order to material_assignments tensor with material_id per face - materials are now returned in alphabetical order - fixed handling of materials for non-homogeneous meshes - fixed skip handling of non-homogeneous meshes Other changes to OBJ importer: - added option to triangulate - added handler to fill in missing materials - added material_name to materials Non-backward compatible changes to USD importer, including: - changes material_order to material_assignments tensor with material_id per face (this is original USD repersentation) - materials are now returned in alphabetical order - removed deprecated handlers in kaolin.io.usd Other changes to USD importer: - major refactoring of the USD importer code; multiple bug fixes; more robust tests - added material_name to materials - added option to triangulate - fixed a bug in USD importer handling of uvs in non-homogeneous meshes Other changes: - deprecated heterogeneous_mesh_handler_naive_homogenize, renaming it mesh_handler_naive_triangulate (as it is not specific to heterogeneous mesh handling) - material assignments are now properly handled during triangulation - modified and simplified notebooks, given changes to API - added multi-object multi-material test file: amsterdam.obj, amsterdam.usd - modified notebooks and recipes to be more robust to missing data (e.g. shapenet) and to run both locally and on CI - added IO consistency checks for OBJ/USD for the new amsterdam mesh - removed heterogeneous_mesh_handler_empty, as we will no longer be able to support it with Mesh API Signed-off-by: Maria Masha Shugrina <[email protected]>
shumash
force-pushed
the
mshugrina/material_order
branch
from
d4772bf to
b8522d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make USD and OBJ importers consistent for all properties, change handling of material assignments, fix bugs, add option to triangulate.
Non-backward compatible changes to OBJ importer, including:
Other changes to OBJ importer:
Non-backward compatible changes to USD importer, including:
Other changes to USD importer:
Other changes: