More robust I/O tests, sample meshes, bug fixes and changes to USD importers #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ities - Added explicit size checks to usd i/o tests; improved tests to not rely on test order execution; made some changes to USD reading code that improves logic flow; fixed documentation error on export_mesh in USD. - Fixed bug in get_scene_paths and added a test - Added three additional test meshes. Started a convention for keeping useful data in one place and referencing it from appropriately named test subfolder. - Added more robust tests for USD meshes; fixed at least one bug; added a partial refactor to usd/mesh.py (not integrated with core readers yet). Removed accidentally added file - Normal consistency spot checks between OBJ and USD now pass; changed small USD samples to human-readable usda version. - Fixed a bug in rtol/atol in a testing function (backward compatible); small improvement to debug logging function - Non-backward compatible changes to USD material import: - stop always prepending material list with None - always output material_order, even if only one material is bound (after all it could be not bound) - Added extensive OBJ/USD consistency checks that at least verify material_order is read consistently. - Added export materials + reimport materials test for an existing test case to ensure read-write-read cycle is not broken. - Adapted obj/usd consistency test to work with multi-mesh USDs. - Fixed a bug: USD transform should apply not only to vertices, but also normals. Signed-off-by: Maria Masha Shugrina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is the first in a series to improve consistency and robustness of our USD and OBJ importers.
Detailed changes: