Add deftet losses #496
Merged
Add deftet losses #496
+446
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Li <michaeli@nvidia.com>
Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com>
Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com>
Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com>
zookae
pushed a commit
to zookae/kaolin
that referenced
this pull request
Mar 30, 2022
* Implementation of loss functions and operations in DefTet with pytests Signed-off-by: Michael Li <michaeli@nvidia.com> * fix naming and doc Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> * fix tests Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> * fix small indent issue Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> * remove torch.abs from tetrahedrons_volume Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> Co-authored-by: Michael Li <michaeli@nvidia.com> Signed-off-by: Alex Zook <azook@nvidia.com>
zookae
pushed a commit
to zookae/kaolin
that referenced
this pull request
Mar 30, 2022
* Implementation of loss functions and operations in DefTet with pytests Signed-off-by: Michael Li <michaeli@nvidia.com> * fix naming and doc Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> * fix tests Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> * fix small indent issue Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> * remove torch.abs from tetrahedrons_volume Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> Co-authored-by: Michael Li <michaeli@nvidia.com> Signed-off-by: Alex Zook <azook@nvidia.com>
zookae
pushed a commit
to zookae/kaolin
that referenced
this pull request
Mar 30, 2022
* Implementation of loss functions and operations in DefTet with pytests Signed-off-by: Michael Li <michaeli@nvidia.com> * fix naming and doc Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> * fix tests Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> * fix small indent issue Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> * remove torch.abs from tetrahedrons_volume Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> Co-authored-by: Michael Li <michaeli@nvidia.com> Signed-off-by: Alex Zook <azook@nvidia.com>
zookae
pushed a commit
to zookae/kaolin
that referenced
this pull request
Mar 31, 2022
* Implementation of loss functions and operations in DefTet with pytests Signed-off-by: Michael Li <michaeli@nvidia.com> * fix naming and doc Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> * fix tests Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> * fix small indent issue Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> * remove torch.abs from tetrahedrons_volume Signed-off-by: Clement Fuji Tsang <cfujitsang@nvidia.com> Co-authored-by: Michael Li <michaeli@nvidia.com> Signed-off-by: Alex Zook <azook@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work is mostly done by @mlej8