feat(rag): add native document retrieval service - #335
Conversation
|
Review findings on current head Blockers
Suggestions
|
|
Addressed the review feedback in
Validation: 79 focused tests passed locally, Ruff passed, and all GitHub checks are green on the updated head. |
9ab7eda to
712a5da
Compare
wenxind-nvidia
left a comment
There was a problem hiding this comment.
Requesting changes on current head 712a5da:
- Rebase onto current
main. The PR is currently unmergeable; merge analysis reports conflicts inDEPENDENCIES.md,README.md,agent-samples/model-servers/main.py,docs/changelog.md, anddocs/source/getting_started/quickstart.md. The branch contains older render/model-server commits overlapping changes already merged through #337. - Please address the two inline findings before rerunning the required checks.
Verification: 8 RAG, 72 models, and 29 launcher tests passed in focused project environments. The combined test project cannot resolve on macOS because PyNvVideoCodec==2.2.0 has no macOS wheel. DCO and CodeQL pass on this head.
Signed-off-by: Devdeep Ray <devdeepr@Nvidia.com>
Signed-off-by: Devdeep Ray <devdeepr@Nvidia.com>
Signed-off-by: Devdeep Ray <devdeepr@Nvidia.com>
Signed-off-by: Devdeep Ray <devdeepr@Nvidia.com>
712a5da to
a2b6dca
Compare
Signed-off-by: Devdeep Ray <devdeepr@Nvidia.com>
|
Addressed the requested changes on the current head |
What
xr_ragNAT function groupWhy
Samples need reusable retrieval without embedding FastMCP or hand-written model HTTP in each worker. This turns the earlier prototype into the current NAT-first architecture: model HTTP stays in
xr-ai-models, retrieval state stays in a typed service, and agents compose ordinary NAT functions.Impact
RAGFunctionsConfigChecks
ruff checkon all changed Python pathsuv run --project tests pytest -q tests/test_rag_service.py tests/test_models_config.py tests/test_models_openai_compat.py tests/test_models_protocols.py tests/test_models_deprecated_aliases.py tests/test_launcher_config.py tests/test_launcher_gpu.pygit diff --check