Fix shared-memory frame size guard - #275
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject frames that exceed a shared-memory slot before claiming or writing to the ring buffer. The error includes the frame dimensions, pixel format, byte count, and configured slot capacity.
This also adds a defensive read-side check for oversized
FrameSignal.data_szvalues, and covers the failure mode with focused regression tests that verify rejected frames do not advance the writer or corrupt the next slot header.Validation
PYTHONPATH=server-runtime:utils/xr-ai-logging uv run --python 3.12 --project agent-sdk --with pytest --with pytest-asyncio --with loguru pytest tests/test_shm_ring_buffer.pyPYTHONPATH=server-runtime:utils/xr-ai-logging TMPDIR=/tmp uv run --python 3.12 --project agent-sdk --with pytest --with pytest-asyncio --with loguru pytest --basetemp=/tmp/xr-ai-pytest tests/test_participant_events.pyuvx ruff check agent-sdk/xr_ai_agent/_shm.py tests/test_shm_ring_buffer.pygit diff --check