cuda/detail/malloc_and_free doesn't include thrust/system/cuda/memory.h

[robertmaynard]

The comments inside cuda/detail/malloc_and_free.h state that
they don't want to include thrust/system/cuda/memory.h as it
is heavy-weight. It was inadvertently doing so through thrust/memory.h,
and so I have correct this oversight.

[robertmaynard]

@brycelelbach I don't see your review.

As for your concern about calling std::free and std::malloc directly. What is the best approach to resolving this. Is including #include <thrust/detail/malloc_and_free.h> and calling thrust::malloc/free okay or is the insufficient for ADL?

Maybe the better question is can thrust::malloc(thrust::seq, ptr) invoke a user defined function or will it always call the version defined in thrust/system/detail/sequential?

[brycelelbach]

@griwes can you take a look at this?

[alliepiper]

Manually rebased on master (the only conflict was a whitespace change).

[alliepiper]

Builds and tests pass locally:

Building thrust.cpp.cuda.cpp11...  ExitCode: 0
Building thrust.cpp.cuda.cpp14...  ExitCode: 0
Building thrust.cpp.cuda.cpp17...  ExitCode: 0
Testing thrust.cpp.cuda.cpp11...   ExitCode: 0   | 100% Pass | 0/273 Fail
Testing thrust.cpp.cuda.cpp14...   ExitCode: 0   | 100% Pass | 0/273 Fail
Testing thrust.cpp.cuda.cpp17...   ExitCode: 0   | 100% Pass | 0/273 Fail

Internal CI started in changelist 28461484.

[alliepiper]

As for your concern about calling std::free and std::malloc directly. What is the best approach to resolving this. Is including #include <thrust/detail/malloc_and_free.h> and calling thrust::malloc/free okay or is the insufficient for ADL?

Maybe the better question is can thrust::malloc(thrust::seq, ptr) invoke a user defined function or will it always call the version defined in thrust/system/detail/sequential?

@robertmaynard I'm guessing you've figured something out by now, but if you still have a question about this, please open up a new issue.

This patch looks fine to me, it just reduces the number of includes to match a documented concern. Unless I hear otherwise I'll merge this after the tests finish.

[robertmaynard]

No concerns, thanks for fixing these issues