This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
First checkpoint for Wconversion warning fixes #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referencing NVIDIA/thrust#1478 and also hand-in-hand with NVIDIA/cub branch bug/github/wconversion-thrust1478 This is to check the style is right and I am following best practices before adding -Wconversions to the gcc build and tackling those warnings. With this branch and the cub branch bug/github/wconversion-thrust1478, the simple reproducer should described in the orignal issue #1478 can build nvcc main.cu -Xcompiler=-Wconversion without warning.
|
Can one of the admins verify this patch? |
|
add to allowlist |
|
DVS CL: 30493510 run tests |
alliepiper
added
testing: gpuCI in progress
alliepiper
approved these changes
Oct 4, 2021
|
Tests pass, LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing NVIDIA/cccl#779 and also hand-in-hand with NVIDIA/cub branch bug/github/wconversion-thrust1478
This is to check the style is right and I am following best practices before adding -Wconversions to the gcc build and tackling those warnings. With this branch and the cub branch bug/github/wconversion-thrust1478, the simple reproducer should described in the orignal issue NVIDIA/cccl#779 can build nvcc main.cu -Xcompiler=-Wconversion without warning.