Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Remove dead code from expand.cu #1476

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Conversation

lilohuang
Copy link
Contributor

No description provided.

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@alliepiper alliepiper self-assigned this Jul 7, 2021
@alliepiper alliepiper added only: tests Changes to tests only. P2: nice to have Desired, but not necessary. labels Jul 7, 2021
@alliepiper alliepiper added this to the 1.14.0 milestone Jul 7, 2021
@alliepiper
Copy link
Collaborator

LGTM -- I'll get this merged soon. Thanks!

@alliepiper
Copy link
Collaborator

Rebased to bring in recent CI fixes.

DVS CL: 30166844

run tests

@alliepiper alliepiper added testing: gpuCI in progress Started gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Jul 8, 2021
@alliepiper alliepiper merged commit 3889d9a into NVIDIA:master Jul 21, 2021
@lilohuang lilohuang deleted the patch-1 branch July 21, 2021 16:49
@lilohuang
Copy link
Contributor Author

Hi @allisonvacanti ,

Somehow the deadcode is still in https://github.com/NVIDIA/thrust/blob/main/examples/expand.cu Perhaps, something went to wrong during merge?

Thanks,
Lilo

@alliepiper
Copy link
Collaborator

Ahh, this was targeted to the old master branch instead of main. I'll fix this up.

@alliepiper
Copy link
Collaborator

Cherry-picked to main in commit 892f5db.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
only: tests Changes to tests only. P2: nice to have Desired, but not necessary. testing: gpuCI in progress Started gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants