Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fix binary search middle calculation to avoid overflows #1306

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Fix binary search middle calculation to avoid overflows #1306

merged 1 commit into from
Oct 14, 2020

Conversation

r-barnes
Copy link
Contributor

@r-barnes r-barnes commented Oct 7, 2020

Addresses #1305

griwes
griwes approved these changes Oct 7, 2020
View reviewed changes
Copy link
Collaborator

@griwes griwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A really nice fix for a somewhat embarrassing bug, thanks ;)

@alliepiper alliepiper added this to the 1.11.0 milestone Oct 12, 2020
@alliepiper
Copy link
Collaborator

DVS CL 29189207.

@alliepiper alliepiper added testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: gpuCI in progress Started gpuCI testing. labels Oct 12, 2020
@alliepiper alliepiper self-assigned this Oct 12, 2020
@alliepiper alliepiper linked an issue Oct 12, 2020 that may be closed by this pull request
Binary search can fail due to overflow error #1305
Closed
@r-barnes r-barnes mentioned this pull request Oct 12, 2020
Closed
@alliepiper alliepiper added testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: gpuCI in progress Started gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Oct 13, 2020
@alliepiper alliepiper merged commit 7749058 into NVIDIA:main Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@griwes griwes griwes approved these changes

Assignees

@alliepiper alliepiper

Labels
testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Binary search can fail due to overflow error
3 participants
@r-barnes @alliepiper @griwes