This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
More correctly detect the presence of aligned/sized new/delete. #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem with the interaction of Clang and libstdc++'s operator new overloads. Also do some drive-by fixes to make sure everything compiles cleanly with Clang and C++17. Bug 2843412
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem with the interaction of Clang and libstdc++'s operator new overloads.
Also do some drive-by fixes to make sure everything compiles cleanly with Clang and C++17.
Internal bug 2843412.
Internal P4 shelved change.
It seems that the issue is caused by libstdc++ using
__cpp_sized_deallocation, with Clang not predefining it unless requested by a flag (https://releases.llvm.org/3.7.0/tools/clang/docs/ReleaseNotes.html#new-compiler-flags) (why in the world would they do it this particular way, i.e. opt in and not opt out, and why in the world would they still hide it behind an opt-in flag, is completely beyond me).