This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix tuple_for_each unused variable macro and tests #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjude
changed the title
|
Submitted internal CI, but it has gaps in C++11 coverage so someone will need to test this locally. @griwes, I'm looking at you. @griwes and @jaredhoberock to code review. |
jaredhoberock
approved these changes
Oct 28, 2019
Right now our main CI basically doesn't test C++11/C++14, we're working on that. Our auxiliary CI (nightly) does. |
|
Passed internal CI, accepting. |
brycelelbach
approved these changes
Oct 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrect macro is used for removing the unused variable warning so this PR corrects that and adds tests for the other 2 tuple algorithms