Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Some async algorithm tests fail on C++17 #1250

Closed
alliepiper opened this issue Aug 5, 2020 · 0 comments · Fixed by #1253
Closed

Some async algorithm tests fail on C++17 #1250

alliepiper opened this issue Aug 5, 2020 · 0 comments · Fixed by #1253
Assignees
Milestone

Comments

@alliepiper
Copy link
Collaborator

It looks like 7ff227a broke some async algorithms on C++17 with gcc 7.5.0.

For example, thrust.cpp.cuda.cpp17.test.async_reduce_into is failing with an "invalid device function" error.

@alliepiper alliepiper added this to the 1.10.0 milestone Aug 5, 2020
@alliepiper alliepiper self-assigned this Aug 5, 2020
alliepiper added a commit to alliepiper/thrust that referenced this issue Aug 6, 2020
…ions.

This partially reverts 7ff227a and
fixes NVIDIA#1250.

I'm not sure why changing these broke the tests, but since these
usages are just testing details that are being refactored by NVIDIA#1251
let's just revert the change for now.

The test failures were only happening on GCC, MSVC was fine with both
versions of these functions, so it may be a compiler issue.
alliepiper added a commit that referenced this issue Aug 12, 2020
…ions.

This partially reverts 7ff227a and
fixes #1250.

I'm not sure why changing these broke the tests, but since these
usages are just testing details that are being refactored by #1251
let's just revert the change for now.

The test failures were only happening on GCC, MSVC was fine with both
versions of these functions, so it may be a compiler issue.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant