Repository navigation
feat(tilert): support per-role engines and TileRT disaggregation - #529
Merged
Merged
Conversation
cquil11
requested review from
alec-flowers,
csahithi,
hjjq,
ishandhanani,
kedarpotdar-nv,
kyleliang-nv,
nlevin-ui and
qiching
as code owners
September 29, 2026 05:13
cquil11
force-pushed
the
feat/tilert-upstream
branch
from
September 29, 2026 18:32
5fa26eb to
1b838c0
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
=======================================
Coverage ? 83.52%
=======================================
Files ? 157
Lines ? 22471
Branches ? 0
=======================================
Hits ? 18769
Misses ? 3702
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RFC: Per-role inference engines and container images (#516).
Adds vLLM-prefill / TileRT-decode disaggregation. I don’t have write permissions here to set up stacked PRs, so the implementation is split into two commits for review:
engineor explicit engines on every role, never both. Unsupported frontend/engine combinations fail before submission.TileRTConnector.The adapter follows TileRT 0.1.6's decode server and router. The public model name comes from vLLM prefill. Native workers no longer inherit Dynamo's launch defaults. Benchmark API limitations are documented in docs/tilert.md.
Validation
Hardware runs used fork revision
b421420b, before rebasing onto current upstream. No new cluster runs or accuracy evaluations were performed for the rebase or review fixes. Locally: both TileRT dry-runs and the shared-engine vLLM dry-run, 548 focused tests, Ruff, Linux-target type checking, and schema checks passed. The broader suite has 21 macOS baseline failures, reproduced on unchanged upstream92fbe04c(including MLPerf snapshot path ordering).InferenceX ports