Skip to content

feat: [AMD Support via SemiAnalysis][4/4] Optional job observation and diagnostics - #476

Open
cquil11 wants to merge 3 commits into
NVIDIA:mainfrom
SemiAnalysisAI:upstream/amd-observation
Open

cquil11 wants to merge 3 commits into
NVIDIA:mainfrom
SemiAnalysisAI:upstream/amd-observation

Conversation

@cquil11

@cquil11 cquil11 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

"Nice to haves" such as job observation and diagnostics, stacked above the complete AMD/MoRI/ATOM implementation. The former required-runtime fixes have moved into #431.

  • srtctl wait streams the allocation log and returns its actual terminal exit status. An empty queue never counts as success; transient observation failures do not resubmit or cancel jobs.
  • Decode non-UTF-8 failure logs without losing useful diagnostics.
  • Capture SGLang Router and MoRI package versions in runtime provenance.

These changes do not enable GPUs, allocate workers, route traffic, or configure KV transfer. Native apply and job execution do not require this PR. The InferenceX CI launcher currently uses wait for observation, so its validation pin includes this optional layer.

Review the stack

The upstream PRs target NVIDIA main and are manually stacked, so later upstream diffs include preceding layers. The downstream fork PRs form an actual branch-based stack (main#1#11#7#14); each fork PR's Files changed tab isolates its layer for easier review.

Merge in that order, then rebase the remaining layers. ATOM uses Mooncake, not MoRI; its stack position is review ordering, not an engine dependency. The core runtime does not require the observation layer, but the InferenceX launcher uses its srtctl wait command.

E2E validation is maintained only in the base PR: upstream #431 / fork #1.

@cquil11 cquil11 changed the title [AMD Support][4/4] Optional job observation and diagnostics feat: [AMD Support][4/4] Optional job observation and diagnostics Sep 17, 2026
@cquil11 cquil11 changed the title feat: [AMD Support][4/4] Optional job observation and diagnostics feat: [AMD Support via SemiAnalysis][4/4] Optional job observation and diagnostics Sep 17, 2026
@cquil11
cquil11 force-pushed the upstream/amd-observation branch 3 times, most recently from 109f2eb to de4cc5f Compare September 18, 2026 21:36
@cquil11
cquil11 force-pushed the upstream/amd-observation branch from de4cc5f to c8ed774 Compare September 22, 2026 18:13
@cquil11
cquil11 force-pushed the upstream/amd-observation branch from c8ed774 to 22f7894 Compare September 23, 2026 04:14

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant