Conversation
cquil11
requested review from
alec-flowers,
csahithi,
ishandhanani and
nlevin-ui
as code owners
September 17, 2026 22:26
cquil11
force-pushed
the
upstream/amd-observation
branch
3 times, most recently
from
September 18, 2026 21:36
109f2eb to
de4cc5f
Compare
cquil11
force-pushed
the
upstream/amd-observation
branch
from
September 22, 2026 18:13
de4cc5f to
c8ed774
Compare
cquil11
requested review from
hjjq,
kedarpotdar-nv,
kyleliang-nv and
qiching
as code owners
September 22, 2026 18:13
This was referenced Sep 22, 2026
cquil11
force-pushed
the
upstream/amd-observation
branch
from
September 23, 2026 04:14
c8ed774 to
22f7894
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Nice to haves" such as job observation and diagnostics, stacked above the complete AMD/MoRI/ATOM implementation. The former required-runtime fixes have moved into #431.
srtctl waitstreams the allocation log and returns its actual terminal exit status. An empty queue never counts as success; transient observation failures do not resubmit or cancel jobs.These changes do not enable GPUs, allocate workers, route traffic, or configure KV transfer. Native
applyand job execution do not require this PR. The InferenceX CI launcher currently useswaitfor observation, so its validation pin includes this optional layer.Review the stack
The upstream PRs target NVIDIA
mainand are manually stacked, so later upstream diffs include preceding layers. The downstream fork PRs form an actual branch-based stack (main→ #1 → #11 → #7 → #14); each fork PR's Files changed tab isolates its layer for easier review.Merge in that order, then rebase the remaining layers. ATOM uses Mooncake, not MoRI; its stack position is review ordering, not an engine dependency. The core runtime does not require the observation layer, but the InferenceX launcher uses its
srtctl waitcommand.E2E validation is maintained only in the base PR: upstream #431 / fork #1.