feat(vllm): support configurable direct serve binary - #409
Merged
Merged
Conversation
Signed-off-by: jiahanc <173873397+jiahanc@users.noreply.github.com>
jiahanc
requested review from
alec-flowers,
csahithi,
ishandhanani and
nlevin-ui
as code owners
September 9, 2026 03:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backend.vllm_serve_binaryfor direct aggregatefrontend.type: vllmjobs.vllmas the default, preserving all existing recipes.vllm-rsor an absolute executable path when the Rust binary is not onPATH.vllm-routerlaunch paths unchanged.Motivation
The direct vLLM backend currently hardcodes
vllm serve. Some vLLM images ship the managed-engine Rust OpenAI frontend asvllm-rs, occasionally only at a package-local absolute path. Recipes need a first-class way to select that executable while retaining srtctl's existing model, topology, port, device, profiling, and vLLM CLI argument construction.Duplicate-work check
No open PR matched searches for
vllm-rs,Rust frontend vllm, orconfigurable serve binaryinNVIDIA/srt-slurm.Tests
.venv/bin/python -m pytest tests/ -v(1753 passed, 2 skipped, 6 deselected).venv/bin/ruff check src/srtctl/.venv/bin/ruff format --check src/srtctl/ tests/test_configs.py.venv/bin/ty check src/srtctl/backends/vllm.pygit diff --checkAI assistance was used to prepare this change. The submitter is responsible for reviewing and understanding every changed line before merge.