feat(observability): default tachometer frequency 1 Hz - #352
Merged
Merged
Conversation
5 Hz produced ~9M rows over a 25-minute production run (job 2806252) with no analysis consuming the extra resolution, and every scrape adds load on the worker endpoints. 1 Hz matches the retired RAW scraper's cadence, so the default capture density is unchanged from what runs relied on before the consolidation. Per-endpoint needs (e.g. DCGM power transients) can still raise it via observability.tachometer. default_frequency. Signed-off-by: Yuewei Na <nv-yna@users.noreply.github.com>
nv-yna
requested review from
alec-flowers,
csahithi,
ishandhanani and
nlevin-ui
as code owners
August 27, 2026 08:59
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
=======================================
Coverage ? 72.02%
=======================================
Files ? 95
Lines ? 13017
Branches ? 0
=======================================
Hits ? 9375
Misses ? 3642
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowers
observability.tachometer.default_frequencyfrom 5 Hz to 1 Hz.Why: 5 Hz produced ~9M rows over a 25-minute production run (job 2806252) with no analysis consuming the extra resolution — the dashboard's panel layer works at 1 Hz — and every scrape adds load on the worker
/metricsendpoints (the same perturbation concern that motivated the complement design in #350). 1 Hz matches the retired RAW scraper's cadence, so default capture density is unchanged from what runs relied on before the consolidation. Recipes that need higher resolution (e.g. DCGM power transients) setdefault_frequencyexplicitly.Default pinned by a new test; docs table + example aligned.
make checkgreen (1463 passed).