Centralize safe runtime port allocation - #156
Merged
Merged
Conversation
weireweire
force-pushed
the
port-safe-range-preflight
branch
5 times, most recently
from
May 14, 2026 07:59
4ed2e83 to
f2785f8
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage ? 65.04%
=======================================
Files ? 67
Lines ? 8207
Branches ? 0
=======================================
Hits ? 5338
Misses ? 2869
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
weireweire
force-pushed
the
port-safe-range-preflight
branch
from
May 14, 2026 08:22
f2785f8 to
70872c4
Compare
weireweire
force-pushed
the
port-safe-range-preflight
branch
from
May 14, 2026 08:41
70872c4 to
fa6c2f3
Compare
weireweire
marked this pull request as ready for review
May 14, 2026 09:41
weireweire
requested review from
alec-flowers,
csahithi,
ishandhanani and
nlevin-ui
as code owners
May 14, 2026 09:41
Collaborator
Author
|
tested on mars and sglang and passed. |
esmeetu
added a commit
to esmeetu/srt-slurm
that referenced
this pull request
May 15, 2026
Resolve conflicts from PR NVIDIA#156 (centralized port allocation) which moved port constants out of per-backend modules. - Delete src/srtctl/backends/mooncake.py (constants now live in ports.py) - Add MOONCAKE_METRICS_PORT (8702) to srtctl/ports.py alongside the existing MOONCAKE_MASTER_PORT (8700) and MOONCAKE_HTTP_METADATA_PORT (8701) so all three live in the same 8700-range - Repoint imports in sglang.py, vllm.py, do_sweep.py, submit.py - Refresh docs/mooncake-kv-store.md and CLAUDE.md to use the new ports - Update test_dry_run.py and test_e2e.py to import port constants from srtctl.ports instead of hardcoding 50051 Workers now see MOONCAKE_MASTER=<infra>:8700 (was 50051) and MOONCAKE_TE_META_DATA_SERVER=http://<infra>:8701/metadata. The mooncake_master srun is launched with explicit --port, --http_metadata_server_port, and --metrics_port flags so we don't rely on mooncake's compile-time defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Validation:
Not run: