[codex] Add SA-Bench DeepSeek V4 tokenizer mode#100
Closed
alec-flowers wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a narrow SA-Bench tokenizer-mode pass-through for DeepSeek V4 without bringing in any recipe payload.
Current
mainalready has the DSV4 custom tokenizer package and the fast chat-template failure with guidance from PR #76. This PR fills the remaining gap fromaflowers/gb200-dsv4-recipes: recipes can now setbenchmark.tokenizer_mode: deepseek_v4, and SA-Bench will pass that through tobenchmark_serving.py.What changed
BenchmarkConfig.tokenizer_mode.SABenchRunnerintobench.shas a new trailing positional argument, preserving the existing dataset arguments.--tokenizer-mode deepseek_v4support inbenchmark_serving.pyandbackend_request_func.py.custom_tokenizer: deepseek_v4as a short alias for the same vLLM DeepSeek V4 tokenizer.Validation
PYTHONPATH=src .venv/bin/python -m pytest tests/ -q-> 612 passed, 2 skipped, 6 deselectedPYTHONPATH=src .venv/bin/python -m pytest tests/test_benchmarks.py tests/test_configs.py -q-> 104 passedUV_PROJECT_ENVIRONMENT=.venv uv run --frozen --no-sync ruff check src/srtctl tests/test_benchmarks.py --ignore SIM117-> passedUV_PROJECT_ENVIRONMENT=.venv uv run --frozen --no-sync ruff format --check src/srtctl tests/test_benchmarks.py-> passedbash -n src/srtctl/benchmarks/scripts/sa-bench/bench.sh-> passedPYTHONPATH=src .venv/bin/python -m py_compile src/srtctl/benchmarks/scripts/sa-bench/backend_request_func.py src/srtctl/benchmarks/scripts/sa-bench/benchmark_serving.py-> passedNote: this intentionally does not port the side-branch auto-fallback behavior for missing chat templates; current
mainalready fails fast with actionable DSV4 guidance instead.