Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hive text file write to deal with CUDF changes #8328

Merged
merged 3 commits into from
May 19, 2023

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented May 19, 2023

Some changes in CUDF made it so that we cannot subclass CudfTableWrtier any more. This switches the needed code over to the new transform API in ColumnarOutputWriter to serve the same purpose.

This is needed before NVIDIA/spark-rapids-jni#1154 is fully in.

@revans2
Copy link
Collaborator Author

revans2 commented May 19, 2023

build

@revans2
Copy link
Collaborator Author

revans2 commented May 19, 2023

build

@revans2
Copy link
Collaborator Author

revans2 commented May 19, 2023

build

Copy link
Collaborator

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, hopefully we can fix these issues soon, if you think it's going to take a while, perhaps adding the issue link to each commented code block would be nice.

@revans2 revans2 merged commit d0f8c83 into NVIDIA:branch-23.06 May 19, 2023
@revans2 revans2 deleted the fix_hive_write branch May 19, 2023 18:06
@sameerz sameerz added the task Work required that improves the product but is not user facing label May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants