Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudf-udf integration test against python3.9 [skip ci] #8233

Merged
merged 2 commits into from
May 8, 2023

Conversation

NvTimLiu
Copy link
Collaborator

@NvTimLiu NvTimLiu commented May 5, 2023

To fix #7773

RAPIDS 23.06 drops python 3.8 packages and supports python3.9 and 3.10

RAPIDS 23.06 drops python 3.8 packages and supports python3.9 and 3.10

Signed-off-by: Tim Liu <[email protected]>
@NvTimLiu NvTimLiu added the build Related to CI / CD or cleanly building label May 5, 2023
@NvTimLiu NvTimLiu requested a review from pxLi May 5, 2023 02:15
@NvTimLiu NvTimLiu self-assigned this May 5, 2023
@NvTimLiu NvTimLiu changed the title cudf-udf integration test against python3.9 cudf-udf integration test against python3.9 [skip ci] May 5, 2023
@pxLi
Copy link
Member

pxLi commented May 5, 2023

as it touchs testing scripts, we cannot skip ci here

@NvTimLiu NvTimLiu changed the title cudf-udf integration test against python3.9 [skip ci] cudf-udf integration test against python3.9 May 5, 2023
@NvTimLiu NvTimLiu changed the title cudf-udf integration test against python3.9 cudf-udf integration test against python3.9 [skip ci] May 5, 2023
pxLi
pxLi previously approved these changes May 5, 2023
# To fix "'lsb_release -a' returned non-zero". ref: https://github.com/pypa/pip/issues/4924
[[ -n "$(which lsb_release)" ]] && mv $(which lsb_release) $(which lsb_release)"-bak"
else
# Set python versiomn to make it the same for both shell mode and batch mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: version

Copy link
Collaborator Author

@NvTimLiu NvTimLiu May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this notation is not needed, we've already set the python version to 3.9 for both batch and shell mode here, when running cudf-udf tests:

https://github.com/NVIDIA/spark-rapids/blob/branch-23.06/jenkins/databricks/cudf_udf_test.sh#L45-L46

@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented May 5, 2023

build

@pxLi pxLi added test Only impacts tests and removed build Related to CI / CD or cleanly building labels May 8, 2023
@pxLi
Copy link
Member

pxLi commented May 8, 2023

Going to merge this one. Lets keep monitoring nightly runs status

@pxLi pxLi merged commit 1948e53 into NVIDIA:branch-23.06 May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] udf test failed cudf-py 23.04 ENV setup on databricks 11.3 runtime
2 participants