Offset support for TakeOrderedAndProject #8226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <[email protected]>
Signed-off-by: Raza Jafri <[email protected]>
revans2
reviewed
May 4, 2023
sql-plugin/src/main/spark340/scala/com/nvidia/spark/rapids/shims/LimitShims.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/spark340/scala/com/nvidia/spark/rapids/shims/LimitShims.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Raza Jafri <[email protected]>
…ffset Signed-off-by: Raza Jafri <[email protected]>
Signed-off-by: Raza Jafri <[email protected]>
Signed-off-by: Raza Jafri <[email protected]>
Signed-off-by: Raza Jafri <[email protected]>
razajafri
force-pushed
the
takeordered-offset
branch
from
873e6af to
e72d5e2
Compare
|
build |
|
Connection problem with DB 3.2.1 |
|
build |
|
Failed again due to connection being refused but this time to DB 330 |
revans2
previously approved these changes
May 5, 2023
|
Just had a few nits on the tests. Nothing critical. Would be happy to merge this in as is, but it would be nice to fix them. |
Signed-off-by: Raza Jafri <[email protected]>
|
build |
revans2
approved these changes
May 5, 2023
|
CI has been failing due to crashed gateway. There is an issue filed for it here I kicked off the CI before I saw the issue was created. |
razajafri
changed the title
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the offset parameter for TakeOrderedAndProjectExec.
fixes #6034