Add oom retry handling for GpuGenerate.fixedLenLazyArrayGenerate #8216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Brennan <[email protected]>
jbrennan333
added
feature request
|
build |
revans2
previously approved these changes
May 3, 2023
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuGenerateExec.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuGenerateExec.scala
Outdated
Show resolved
Hide resolved
|
build |
|
build |
|
@revans2 can you take another look? |
revans2
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8196.
Closes #1940.
In #8167 we added oom retry handling to the doGenerate path for GpuGenerateExec.
This patch adds oom retries to the other path,
GpuGenerateExec.fixedLenLazyArrayGenerate.I did some refactoring to combine the two separate project calls into one, and use
GpuProjectExec.projectAndCloseWithRetrySingleBatchto handle the retries for the single project.I tested this by running the
generate_expr_test.pyintegration tests with--test_oom_injection_mode always.